From: Shawn O. Pearce <spearce@spearce.org>
Date: Sun, 24 Jan 2010 00:03:05 GMT
Subject: Re: [PATCH] git-gui: set GIT_DIR and GIT_WORK_TREE after setup
Message-ID: <20100124000305.GK12679@spearce.org>
In-Reply-To: <1264291140-16595-1-git-send-email-giuseppe.bilotta@gmail.com>

Giuseppe Bilotta <giuseppe.bilotta@gmail.com> wrote:
> Rather than juggling with the env var GIT_DIR around the invocation of
> gitk, set it and GIT_WORK_TREE after finishing setup, ensuring that any
> external tool works with the setup we're running with.
> 
> This also allows us to remove a couple of conditionals when running gitk
> or git gui in a submodule, as we know that the variables are present and
> have to be unset and reset before and after the invocation.
> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> ---
>  git-gui.sh |   43 ++++++++++++++++++++-----------------------
>  1 files changed, 20 insertions(+), 23 deletions(-)

Thanks, applied.

-- 
Shawn.