git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] commit/status: "git add <path>" is not necessarily how to resolve

From
Jeff King <peff@peff.net>
Date
Dec 12, 2009, 09:15 UTC
Message-ID
<20091212091556.GA30509@coredump.intra.peff.net>
In-Reply-To
<1260608523-15579-3-git-send-email-gitster@pobox.com>
On Sat, Dec 12, 2009 at 01:02:02AM -0800, Junio C Hamano wrote:
> When the desired resolution is to remove the path, "git rm <path>" is the
> command the user needs to use.  Just like in "Changed but not updated"
> section, suggest to use "git add/rm" as appropriate.

I no longer even see these messages due to advice.statushints, but the overall direction of the series looks sane to me.

However:
> -	color_fprintf_ln(s->fp, c, "#   (use \"git add <file>...\" to mark resolution)");
> +	color_fprintf_ln(s->fp, c, "#   (use \"git add/rm <file>...\" as appropriately to mark resolution)");
This should be "as appropriate".
-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 10 in “Update advice in commit/status output”
  1. 0/3 Update advice in commit/status outputJunio C Hamano, Dec 12, 2009
  2. 1/3 commit/status: check $GIT_DIR/MERGE_HEAD only onceJunio C Hamano, Dec 12, 2009
  3. 2/3 commit/status: "git add <path>" is not necessarily how to resolveJunio C Hamano, Dec 12, 2009
  4. 3/3 status/commit: do not suggest "reset HEAD <path>" while mergingJunio C Hamano, Dec 12, 2009
  5. Jeff KingDec 12, 2009
  6. Junio C HamanoDec 12, 2009
  7. Nanako ShiraishiDec 12, 2009
  8. Sverre RabbelierDec 12, 2009
  9. Junio C HamanoDec 12, 2009
  10. Jay SoffianDec 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.