git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 2/6] reset: use "unpack_trees()" directly instead of "git read-tree"

From
Christian Couder <chriscool@tuxfamily.org>
Date
Dec 12, 2009, 04:19 UTC
Message-ID
<200912120519.04328.chriscool@tuxfamily.org>
In-Reply-To
<1260261919.1554.11.camel@swboyd-laptop>
On mardi 08 décembre 2009, Stephen Boyd wrote:
Show 14 quoted lines
> On Tue, 2009-12-08 at 08:56 +0100, Christian Couder wrote:
> > +static int parse_and_init_tree_desc(const unsigned char *sha1,
> > +					     struct tree_desc *desc)
> > +{
> > +	struct tree *tree = parse_tree_indirect(sha1);
> > +	if (!tree)
> > +		return 1;
> > +	init_tree_desc(desc, tree->buffer, tree->size);
> > +	return 0;
> > +}
> > +
>
> Is there a reason why you use this function instead of
> fill_tree_descriptor()?

I didn't know about fill_tree_descriptor(). I will use it in the next series.

Thanks, Christian.

Previous: Stephen BoydNext: Christian Couder
Message 5 of 10 in “"git reset --merge" related improvements”
  1. 0/6 "git reset --merge" related improvementsChristian Couder, Dec 8, 2009
  2. 1/6 reset: add a few tests for "git reset --merge"Christian Couder, Dec 8, 2009
  3. 2/6 reset: use "unpack_trees()" directly instead of "git read-tree"Christian Couder, Dec 8, 2009
  4. Stephen BoydDec 8, 2009
  5. Christian CouderDec 12, 2009
  6. 3/6 reset: add option "--keep-local-changes" to "git reset"Christian Couder, Dec 8, 2009
  7. 4/6 reset: add test cases for "--keep-local-changes" optionChristian Couder, Dec 8, 2009
  8. 5/6 Documentation: reset: describe new "--keep-local-changes" optionChristian Couder, Dec 8, 2009
  9. 6/6 Documentation: reset: add some tables to describe the different optionsChristian Couder, Dec 8, 2009
  10. Junio C HamanoDec 8, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.