From: Christian Couder <chriscool@tuxfamily.org>
Date: Sat, 12 Dec 2009 04:19:03 GMT
Subject: Re: [PATCH v4 2/6] reset: use "unpack_trees()" directly instead of "git read-tree"
Message-ID: <200912120519.04328.chriscool@tuxfamily.org>
In-Reply-To: <1260261919.1554.11.camel@swboyd-laptop>

On mardi 08 décembre 2009, Stephen Boyd wrote:
> On Tue, 2009-12-08 at 08:56 +0100, Christian Couder wrote:
> > +static int parse_and_init_tree_desc(const unsigned char *sha1,
> > +					     struct tree_desc *desc)
> > +{
> > +	struct tree *tree = parse_tree_indirect(sha1);
> > +	if (!tree)
> > +		return 1;
> > +	init_tree_desc(desc, tree->buffer, tree->size);
> > +	return 0;
> > +}
> > +
>
> Is there a reason why you use this function instead of
> fill_tree_descriptor()?

I didn't know about fill_tree_descriptor(). I will use it in the next 
series.

Thanks,
Christian.