git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH RFC] rebase: add --revisions flag

From
MTMichael S. Tsirkin <mst@redhat.com>
Date
Dec 9, 2009, 14:12 UTC
Message-ID
<20091209141208.GM2977@redhat.com>
In-Reply-To
<20091209140145.GA31130@atjola.homenet>
On Wed, Dec 09, 2009 at 03:01:45PM +0100, Björn Steinbrink wrote:
Show 35 quoted lines
> On 2009.12.09 15:45:36 +0200, Michael S. Tsirkin wrote:
> > On Wed, Dec 09, 2009 at 02:30:06PM +0100, Matthieu Moy wrote:
> > > Junio C Hamano <gitster@pobox.com> writes:
> > > 
> > > > So perhaps a good way to move forward is to teach "git cherry-pick A..B"
> > > > to be a thin wrapper that invokes a new hidden mode of operation added to
> > > > "rebase" that is not advertised to the end user.
> > > >
> > > > I would suggest calling the option to invoke that hidden mode not
> > > > "--revisions", but "--reverse" or "--opposite" or something of that
> > > > nature, though.  It makes "rebase" work in different direction.
> > > 
> > > Intuitively,
> > > 
> > >   git rebase --reverse A..B
> > > 
> > > would mean "take the range A..B, and start applying the patches from
> > > B, going in reverse order up to A", like "git log --reverse". So, I'd
> > > find it misleading.
> > > 
> > > Perhaps "git rebase --cherry-pick A..B" would be a better name. No
> > > objection for --opposite either.
> > 
> > I relly like --cherry-pick. Junio, objections to that one?
> 
> Hm, there's also (the probably not so well known)
> "git rev-list --cherry-pick A...B", which excludes commits that appear
> on both A and B and have the same patch id. I'd rather call the rev-list
> option a misnomer than the suggested hidden option for rebase, but I'd
> call it --cherry-pick-mode or --cherry-picking (like am's hidden "git am
> --rebasing"), just to make sure... Of course, it's not _that_ important,
> as it's going to be a hidden option, so user confusion is probably not
> that much of a concern.
> 
> Björn
OK, --cherry-picking looks fine as well.
Previous: Björn SteinbrinkNext: Junio C Hamano
Message 41 of 43 in “rebase: add --revisions flag”
  1. rebase: add --revisions flagMichael S. Tsirkin, Dec 8, 2009
  2. Björn SteinbrinkDec 8, 2009
  3. Michael S. TsirkinDec 8, 2009
  4. Björn SteinbrinkDec 8, 2009
  5. Michael S. TsirkinDec 8, 2009
  6. Björn SteinbrinkDec 8, 2009
  7. Michael S. TsirkinDec 8, 2009
  8. Björn SteinbrinkDec 8, 2009
  9. Michael S. TsirkinDec 8, 2009
  10. Björn SteinbrinkDec 8, 2009
  11. Michael S. TsirkinDec 8, 2009
  12. Björn SteinbrinkDec 9, 2009
  13. Michael S. TsirkinDec 9, 2009
  14. Miles BaderDec 9, 2009
  15. Junio C HamanoDec 8, 2009
  16. Sverre RabbelierDec 8, 2009
  17. Christian CouderDec 9, 2009
  18. Christian CouderDec 9, 2009
  19. Sverre RabbelierDec 9, 2009
  20. Peter KreftingDec 9, 2009
  21. Michael S. TsirkinDec 9, 2009
  22. Peter KreftingDec 9, 2009
  23. Björn SteinbrinkDec 9, 2009
  24. Andreas SchwabDec 9, 2009
  25. Björn SteinbrinkDec 9, 2009
  26. Michael S. TsirkinDec 9, 2009
  27. Björn SteinbrinkDec 9, 2009
  28. Junio C HamanoDec 9, 2009
  29. Björn SteinbrinkDec 10, 2009
  30. Junio C HamanoDec 10, 2009
  31. Björn SteinbrinkDec 11, 2009
  32. Peter KreftingDec 9, 2009
  33. Björn SteinbrinkDec 9, 2009
  34. Peter KreftingDec 10, 2009
  35. Björn SteinbrinkDec 10, 2009
  36. Michael S. TsirkinDec 9, 2009
  37. Matthieu MoyDec 9, 2009
  38. Matthieu MoyDec 9, 2009
  39. Michael S. TsirkinDec 9, 2009
  40. Björn SteinbrinkDec 9, 2009
  41. Michael S. TsirkinDec 9, 2009
  42. Junio C HamanoDec 9, 2009
  43. David KågedalDec 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.