Re: [PATCH RFC] rebase: add --revisions flag

> Hi,
>
> On mardi 08 décembre 2009, Sverre Rabbelier wrote:
> > Heya,
> >
> > On Tue, Dec 8, 2009 at 21:22, Junio C Hamano <gitster@pobox.com> wrote:
> > > But I think it is a reasonable thing to _implement_ the feature to
> > > range-pick commits reusing the sequencing logic already in "rebase"
> > > and "rebase -i".  That essentially is what we wanted to do with "git
> > > sequencer" that would be a sequencing logic backend shared among
> > > rebase, cherry-pick, and perhaps am.
> >
> > Speaking of which, what's the status of git sequencer? I seem to
> > remember some activity recently to slowly rewrite git rebase in c, but
> > I haven't seen anything since then. Is it still moving forward? Is
> > anyone interested in doing so? Just curious...
>
> Last June and July, I sent some patch series to port "rebase -i" to C
> using code from the sequencer project. My goal was to save some
> interesting code from the sequencer GSoC 2008 project and at the same
> time to move forward "rebase -i" code toward a sequencer.
>
> But Dscho and Junio didn't like the fact that the code from the sequencer
> I added was duplicating existing code and was not properly refactored,
> though it also added things that would be needed later for the sequencer.
> My plan was to refactor later, once I had a sequencer, but Junio and
> Dscho did not like that plan. They said it would be a too big maintenance
> burden.
>
> So I agreed to not duplicate any existing code and to properly refactor
> everything. And I have been trying to take interesting and useful code
> from the sequencer project and to integrate it into existing commands.
> And this is why I sent yesterday the 4th version of my '"git reset
> --merge" related improvements' patch series.