Re: [RFC PATCH v2 2/2] MSVC: Fix an "incompatible pointer types" compiler warning
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Dec 5, 2009, 11:57 UTC
- Message-ID
- <200912051257.21386.j6t@kdbg.org>
- In-Reply-To
- <4B1997A0.9000004@ramsay1.demon.co.uk>
[Removed Junio from Cc because IIUC, he prefers to be left out of the loop in Windows related matters until they have settled.]
On Samstag, 5. Dezember 2009, Ramsay Jones wrote:
> The patch is still marked RFC because: > - I'm still not sure if the flexibility to support both 32- and 64-bit > time_t is required. > - should -D_USE_32BIT_TIME_T be added to the Makefile?
If *not* using -D_USE_32BIT_TIME_T produces a build or code base that is in some way superior, why should we require it? For example, its absence could help a 64bit build.
-- Hannes