git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCHv9 01/11] fast-import: Proper notes tree manipulation

From
Johan Herland <johan@herland.net>
Date
Dec 2, 2009, 22:41 UTC
Message-ID
<200912022341.55474.johan@herland.net>
In-Reply-To
<20091202203953.GE31648@spearce.org>
On Wednesday 02 December 2009, Shawn O. Pearce wrote:
Show 7 quoted lines
> Johan Herland <johan@herland.net> wrote:
> > diff --git a/fast-import.c b/fast-import.c
> > index b41d29f..b51ffbc 100644
> > --- a/fast-import.c
> > +++ b/fast-import.c
> 
> This new version is much cleaner, thank you.
Thank you for the suggestions that made it so :)

The rest of your comments all make perfect sense. I'll whip up a replacement patch shortly.

Thanks for the review!
...Johan
-- 
Johan Herland, <johan@herland.net>
www.herland.net
Previous: Shawn O. PearceNext: Johan Herland
Message 4 of 15 in “[RFC/PATCHv9 00/11] git notes”
  1. Johan HerlandDec 2, 2009
  2. 01/11 fast-import: Proper notes tree manipulationJohan Herland, Dec 2, 2009
  3. Shawn O. PearceDec 2, 2009
  4. Johan HerlandDec 2, 2009
  5. Johan HerlandDec 3, 2009
  6. 02/11 Rename t9301 to t9350, to make room for more fast-import testsJohan Herland, Dec 2, 2009
  7. 03/11 Add more testcases to test fast-import of notesJohan Herland, Dec 2, 2009
  8. 04/11 Minor style fixes to notes.cJohan Herland, Dec 2, 2009
  9. 05/11 Notes API: get_commit_notes() -> format_note() + remove the commit restrictionJohan Herland, Dec 2, 2009
  10. 06/11 Notes API: init_notes(): Initialize the notes tree from the given notes refJohan Herland, Dec 2, 2009
  11. 07/11 Notes API: add_note(): Add note objects to the internal notes tree structureJohan Herland, Dec 2, 2009
  12. 08/11 Notes API: get_note(): Return the note annotating the given objectJohan Herland, Dec 2, 2009
  13. 09/11 Notes API: for_each_note(): Traverse the entire notes tree with a callbackJohan Herland, Dec 2, 2009
  14. 10/11 Notes API: Allow multiple concurrent notes trees with new struct notes_treeJohan Herland, Dec 2, 2009
  15. 11/11 Refactor notes concatenation into a flexible interface for combining notesJohan Herland, Dec 2, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.