git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC/PATCHv9 07/11] Notes API: add_note(): Add note objects to the internal notes tree structure

From
Johan Herland <johan@herland.net>
Date
Dec 2, 2009, 02:09 UTC
Message-ID
<1259719783-4674-8-git-send-email-johan@herland.net>
In-Reply-To
<1259719783-4674-1-git-send-email-johan@herland.net>
Signed-off-by: Johan Herland <johan@herland.net>
---
 notes.c |   11 +++++++++++
 notes.h |    4 ++++
 2 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/notes.c b/notes.c
index 23e62dd..3c8a6e0 100644
--- a/notes.c
+++ b/notes.c
@@ -366,6 +366,17 @@ void init_notes(const char *notes_ref, int flags)
 	load_subtree(&root_tree, &root_node, 0);
 }
 
+void add_note(const unsigned char *object_sha1, const unsigned char *note_sha1)
+{
+	struct leaf_node *l;
+
+	assert(initialized);
+	l = (struct leaf_node *) xmalloc(sizeof(struct leaf_node));
+	hashcpy(l->key_sha1, object_sha1);
+	hashcpy(l->val_sha1, note_sha1);
+	note_tree_insert(&root_node, 0, l, PTR_TYPE_NOTE);
+}
+
 static unsigned char *lookup_notes(const unsigned char *object_sha1)
 {
 	struct leaf_node *found = note_tree_find(&root_node, 0, object_sha1);
diff --git a/notes.h b/notes.h
index 6b52799..5f22852 100644
--- a/notes.h
+++ b/notes.h
@@ -21,6 +21,10 @@
  */
 void init_notes(const char *notes_ref, int flags);
 
+/* Add the given note object to the internal notes tree structure */
+void add_note(const unsigned char *object_sha1,
+		const unsigned char *note_sha1);
+
 /* Free (and de-initialize) the internal notes tree structure */
 void free_notes(void);
 
-- 
1.6.5.3.433.g11067
Previous: Johan HerlandNext: Johan Herland
Message 11 of 15 in “[RFC/PATCHv9 00/11] git notes”
  1. Johan HerlandDec 2, 2009
  2. 01/11 fast-import: Proper notes tree manipulationJohan Herland, Dec 2, 2009
  3. Shawn O. PearceDec 2, 2009
  4. Johan HerlandDec 2, 2009
  5. Johan HerlandDec 3, 2009
  6. 02/11 Rename t9301 to t9350, to make room for more fast-import testsJohan Herland, Dec 2, 2009
  7. 03/11 Add more testcases to test fast-import of notesJohan Herland, Dec 2, 2009
  8. 04/11 Minor style fixes to notes.cJohan Herland, Dec 2, 2009
  9. 05/11 Notes API: get_commit_notes() -> format_note() + remove the commit restrictionJohan Herland, Dec 2, 2009
  10. 06/11 Notes API: init_notes(): Initialize the notes tree from the given notes refJohan Herland, Dec 2, 2009
  11. 07/11 Notes API: add_note(): Add note objects to the internal notes tree structureJohan Herland, Dec 2, 2009
  12. 08/11 Notes API: get_note(): Return the note annotating the given objectJohan Herland, Dec 2, 2009
  13. 09/11 Notes API: for_each_note(): Traverse the entire notes tree with a callbackJohan Herland, Dec 2, 2009
  14. 10/11 Notes API: Allow multiple concurrent notes trees with new struct notes_treeJohan Herland, Dec 2, 2009
  15. 11/11 Refactor notes concatenation into a flexible interface for combining notesJohan Herland, Dec 2, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.