Re: [RFC PATCH 4/8] Support remote helpers implementing smart transports

From: Shawn O. Pearce <spearce@spearce.org>
Date: Dec 2, 2009, 17:04 UTC
Message-ID: <20091202170457.GC31648@spearce.org>
In-Reply-To: <20091202055543.GC31244@Knoppix>

Ilari Liusvaara <ilari.liusvaara@elisanet.fi> wrote:

Show 6 quoted lines

> On Tue, Dec 01, 2009 at 11:22:33AM -0800, Shawn O. Pearce wrote:
> > Why both connect-r and invoke-r?  Why isn't connect-r sufficient
> > here?  Isn't it sufficient for any service that runs over git:// ?
> 
> Invoke supports those --upload-pack &co (a'la ssh://). connect
> doesn't (a'la to git://).

Drop invoke-r.

Modify transport-helper.c to allow pushing TRANS_OPT_UPLOADPACK and TRANS_OPT_RECEIVEPACK down into the helper via the option capability.

I'd rename connect-r to just connect.

For the command line:

  $ git fetch --upload-pack='/path to my /git-upload-pack' origin

The conversation with the helper will be:

  > capabilities
  < option
  < connect
  <
  > option uploadpack /path to my /git-upload-pack
  < ok
  > connect git-upload-pack
  <

Which gives the helper the full information it needs to pass along the --upload-pack command line argument to the remote system.

-- 
Shawn.