git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: Use git-difftool for external diffs

From
Markus Heidelberg <markus.heidelberg@web.de>
Date
Nov 20, 2009, 23:33 UTC
Message-ID
<200911210033.42661.markus.heidelberg@web.de>
In-Reply-To
<20091120185522.GC56351@gmail.com>
David Aguilar, 2009-11-20:
> The argument in favor of difftool is one of user
> expectations.  From a user's POV it ~seems~ desirable for
> gitk to honor difftool configurations.

In general I absolutely like the idea. There are however problems you can encounter. I use vimdiff for git-difftool and gvimdiff for gitk. When testing gitk with your patch, I wondered where the editor is, because nothing popped up. I then found vim on the terminal from where I started gitk. Even worse: when started with "gitk &", the vim process runs somewhere in the background and gitk freezes.

To overcome this problem maybe we need a second config variable like diff.guitool.

Markus
Previous: David AguilarNext: Nanako Shiraishi
Message 9 of 13 in “gitk: Use git-difftool for external diffs”
  1. gitk: Use git-difftool for external diffsDavid Aguilar, Nov 16, 2009
  2. Paul MackerrasNov 19, 2009
  3. David AguilarNov 19, 2009
  4. Paul MackerrasNov 19, 2009
  5. Junio C HamanoNov 20, 2009
  6. David AguilarNov 20, 2009
  7. Junio C HamanoNov 20, 2009
  8. David AguilarNov 21, 2009
  9. Markus HeidelbergNov 20, 2009
  10. Nanako ShiraishiDec 30, 2009
  11. Junio C HamanoDec 30, 2009
  12. David AguilarDec 31, 2009
  13. Junio C HamanoDec 31, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.