From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Fri, 20 Nov 2009 23:33:42 GMT
Subject: Re: [PATCH] gitk: Use git-difftool for external diffs
Message-ID: <200911210033.42661.markus.heidelberg@web.de>
In-Reply-To: <20091120185522.GC56351@gmail.com>

David Aguilar, 2009-11-20:
> The argument in favor of difftool is one of user
> expectations.  From a user's POV it ~seems~ desirable for
> gitk to honor difftool configurations.

In general I absolutely like the idea. There are however problems you
can encounter.
I use vimdiff for git-difftool and gvimdiff for gitk. When testing gitk
with your patch, I wondered where the editor is, because nothing popped
up. I then found vim on the terminal from where I started gitk. Even
worse: when started with "gitk &", the vim process runs somewhere in the
background and gitk freezes.

To overcome this problem maybe we need a second config variable like
diff.guitool.

Markus