Re: [PATCH] Doc: mention the crlf attribute in config autocrlf section

From: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
Date: Nov 17, 2009, 07:43 UTC
Message-ID: <20091117074330.GA2813@comcast.net>
In-Reply-To: <7v7htpirmy.fsf@alter.siamese.dyndns.org>

On Mon, Nov 16, 2009 at 10:37:09PM -0800, Junio C Hamano wrote:

Show 19 quoted lines

> How about this?  I didn't touch the patch text (other than dropping
> trailing whitespaces).
> 
> commit ff68668695486b72b5f06146eddf85b70841088a
> Author: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
> Date:   Sat Nov 14 11:35:00 2009 -0700
> 
>     core.autocrlf documentation: mention the crlf attribute
>     
>     The description of the configuration variable is obsolete and
>     wrong (saying only file content is used), not just incomplete.
>     It has used the attribute mechanism for a long time.
>     
>     The documentation of gitattributes mentions the core.autocrlf
>     configuration variable in its description of crlf attribute.
>     Refer to the gitattributes documentation from here as well.
>     
>     Signed-off-by: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
>     Signed-off-by: Junio C Hamano <gitster@pobox.com>

Looks good. Sorry about the extra space in the patch text; stripping it sounds good as well.

-- Matthew Ogilvie [mmogilvi_git@miniinfo.net]