git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] http-backend: Let gcc check the format of more printf-type functions.

From
Shawn O. Pearce <spearce@spearce.org>
Date
Nov 16, 2009, 01:39 UTC
Message-ID
<20091116013911.GY11919@spearce.org>
In-Reply-To
<1258233058-2348-2-git-send-email-tarmigan+git@gmail.com>
Tarmigan Casebolt <tarmigan+git@gmail.com> wrote:
Show 9 quoted lines
> We already have these checks in many printf-type functions that have
> prototypes which are in header files.  Add these same checks to
> static functions in http-backend.c
> 
> Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>
> ---
> 
> Shawn, please consider this patch in addition to the one that you posted 
> that actually fixes the bug.  With this patch, gcc will warn about that bug.
Yup, it would have caught it, thanks.
Acked-by: Shawn O. Pearce <spearce@spearce.org>
 
-- 
Shawn.
Previous: Tarmigan CaseboltNext: Shawn O. Pearce
Message 3 of 8 in “http-backend: Fix access beyond end of string.”
  1. 1/2 http-backend: Fix access beyond end of string.Tarmigan Casebolt, Nov 14, 2009
  2. 2/2 http-backend: Let gcc check the format of more printf-type functions.Tarmigan Casebolt, Nov 14, 2009
  3. Shawn O. PearceNov 16, 2009
  4. Shawn O. PearceNov 16, 2009
  5. Jeff KingNov 16, 2009
  6. Junio C HamanoNov 16, 2009
  7. TarmiganNov 17, 2009
  8. Brian GernhardtNov 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.