Re: [PATCH] clone: detect extra arguments
- From
Jeff King <peff@peff.net>
- Date
- Oct 30, 2009, 14:45 UTC
- Message-ID
- <20091030144525.GA22583@coredump.intra.peff.net>
- In-Reply-To
- <20091030111919.GA13242@progeny.tock>
On Fri, Oct 30, 2009 at 06:19:19AM -0500, Jonathan Nieder wrote:
> > Should we maybe be showing the usage in this case? > > Sounds reasonable. How about this patch on top?
I do think it's an improvement, but...
Show 6 quoted lines
> -- %< -- > Subject: [PATCH] clone: print usage on wrong number of arguments > > git clone's short usage string is only 22 lines, so an error > message plus usage string still fits comfortably on an 80x24 > terminal.
The extra blank lines introduced by usage_msg_opt make it 25 lines, scrolling the message right off of my terminal screen. ;)
But looking at the usage message, there is some potential for cleanup. So maybe this on top (or between your 1 and 2)?
-- >8 -- Subject: [PATCH] clone: hide "naked" option from usage message
This is just a little-known synonym for bare, and there is little point in advertising both (we don't even include it in the manpage). Removing it also makes the usage message one line shorter, giving just enough room for an information message in a 24-line terminal.
Signed-off-by: Jeff King <peff@peff.net> --- builtin-clone.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/builtin-clone.c b/builtin-clone.c index 736d9e1..ce0d79a 100644 --- a/builtin-clone.c +++ b/builtin-clone.c @@ -51,7 +51,9 @@ static struct option builtin_clone_options[] = { OPT_BOOLEAN('n', "no-checkout", &option_no_checkout, "don't create a checkout"), OPT_BOOLEAN(0, "bare", &option_bare, "create a bare repository"), - OPT_BOOLEAN(0, "naked", &option_bare, "create a bare repository"), + { OPTION_BOOLEAN, 0, "naked", &option_bare, NULL, + "create a bare repository", + PARSE_OPT_NOARG | PARSE_OPT_HIDDEN }, OPT_BOOLEAN(0, "mirror", &option_mirror, "create a mirror repository (implies bare)"), OPT_BOOLEAN('l', "local", &option_local,
-- 1.6.5.1.143.g1dab74.dirty