Re: [PATCH] clone: detect extra arguments

From

Jeff King <peff@peff.net>

Date

Oct 29, 2009, 16:06 UTC

Message-ID

<20091029160614.GB7622@sigill.intra.peff.net>

In-Reply-To

<20091029081030.GA11213@progeny.tock>

On Thu, Oct 29, 2009 at 03:10:30AM -0500, Jonathan Nieder wrote:

> If git clone is given more than two non-option arguments, it
> silently throws away all but the first one.  Complain instead.
> [...]
> +	if (argc > 2)
> +		die("Too many arguments.");
> +

Should we maybe be showing the usage in this case?

>  	if (argc == 0)
>  		die("You must specify a repository to clone.");

Probably we should do the same here, too.

-Peff