git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t/test-lib.sh: support Korn shell by converting GIT_EXIT_OK to GIT_EXIT_CODE

From
Jeff King <peff@peff.net>
Date
Oct 10, 2009, 14:03 UTC
Message-ID
<20091010140336.GB16827@sigill.intra.peff.net>
In-Reply-To
<1255178966-sup-5813@ntdws12.chass.utoronto.ca>
On Sat, Oct 10, 2009 at 08:53:00AM -0400, Ben Walton wrote:
Show 7 quoted lines
> > According to the autoconf docs this bug is also present in the Solaris
> > /bin/sh (and autoconf generated scripts use some elaborated workaround).
> 
> Solaris' /bin/sh shouldn't be used for anything but forking a decent
> shell, imo.  It was brought to my attention recently that the test
> suite for mercurial on solaris was failing the git tests.  The
> mercurial folks initially thought this was a git on solaris bug.

Yes, that is the attitude we take towards /bin/sh on Solaris. Most people running git on Solaris (or other broken-shell platforms) point SHELL_PATH to bash. I think the point of Brandon's patch is to let them use a native shell.

So while /bin/sh is broken, the question is whether the alternate native shell is broken enough to use or not.

-Peff
Previous: Ben Walton
Message 11 of 11 in “t/test-lib.sh: support Korn shell by converting GIT_EXIT_OK to GIT_EXIT_CODE”
  1. 1/2 t/test-lib.sh: support Korn shell by converting GIT_EXIT_OK to GIT_EXIT_CODEBrandon Casey, Oct 9, 2009
  2. 2/2 Makefile: use the native (Korn) shell on SunOS and IRIX/IRIX64Brandon Casey, Oct 9, 2009
  3. Jonathan NiederOct 9, 2009
  4. Jonathan NiederOct 9, 2009
  5. Junio C HamanoOct 9, 2009
  6. Brandon CaseyOct 9, 2009
  7. Junio C HamanoOct 10, 2009
  8. Clemens BuchacherOct 10, 2009
  9. Andreas SchwabOct 10, 2009
  10. Ben WaltonOct 10, 2009
  11. Jeff KingOct 10, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.