From: Jeff King <peff@peff.net>
Date: Sat, 10 Oct 2009 14:03:36 GMT
Subject: Re: [PATCH 1/2] t/test-lib.sh: support Korn shell by converting GIT_EXIT_OK to GIT_EXIT_CODE
Message-ID: <20091010140336.GB16827@sigill.intra.peff.net>
In-Reply-To: <1255178966-sup-5813@ntdws12.chass.utoronto.ca>

On Sat, Oct 10, 2009 at 08:53:00AM -0400, Ben Walton wrote:

> > According to the autoconf docs this bug is also present in the Solaris
> > /bin/sh (and autoconf generated scripts use some elaborated workaround).
> 
> Solaris' /bin/sh shouldn't be used for anything but forking a decent
> shell, imo.  It was brought to my attention recently that the test
> suite for mercurial on solaris was failing the git tests.  The
> mercurial folks initially thought this was a git on solaris bug.

Yes, that is the attitude we take towards /bin/sh on Solaris. Most
people running git on Solaris (or other broken-shell platforms) point
SHELL_PATH to bash. I think the point of Brandon's patch is to let them
use a native shell.

So while /bin/sh is broken, the question is whether the alternate native
shell is broken enough to use or not.

-Peff