Re: [PATCH] tests: make all test files executable

From: Jeff King <peff@peff.net>
Date: Oct 6, 2009, 10:00 UTC
Message-ID: <20091006100016.GA30404@coredump.intra.peff.net>
In-Reply-To: <4ACAA15E.6090403@mailservices.uwaterloo.ca>

On Mon, Oct 05, 2009 at 09:46:06PM -0400, Mark Rada wrote:

> 	No changes, just a resend. This should work; I assume
> 	the problem last time was a human error (me :(), or
> 	something weird that happens with saving e-mail drafts
> 	between	Apple Mail and Thunderbird (they share).

This version looks fine (though I fixed up and applied the old one, so it is only useful as an experment). Whatever you did differently worked. :)

> 	Jeff, please explain what you meant by `inscrutable
> 	binary'? It is an ASCII text file according to file.
> 	¯\(°_o)/¯

When I looked at in mutt, it was full of binary garbage. But looking at it more closely, the attachment is bogus. Look at:

  http://article.gmane.org/gmane.comp.version-control.git/129522/raw

You have a message/rfc822 attachment which claims to be encoded using base64. But there's a bunch of extra text at the top before the base64 starts, which throws off the decoding, leading to the binary garbage.

So the .eml format appears to be a subset of the headers, followed by the base64-encoded body. But your mail client, in attaching it, marked it as base64-encoded, which is just wrong. But in theory that is a problem in transporting the file to the list. For you to "git am" it yourself, we'll assume you saw the raw contents.

Even then, it is still a confusing format. Instead of the headers looking like

  From: whatever

there is a line break, so they appear as

  From:
  whatever

and of course there are no mime headers indicating that body is base64-encoded. So it is definitely not an rfc822 message, which is what "git am" is expecting.

-Peff