threads / patch / 21138

patchtests: make all test files executable

Subject: [PATCH] tests: make all test files executable

## tl;dr

2 messages between Oct 6, 2009 and Oct 6, 2009. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Mark Rada· Oct 6, 2009, 01:46 UTC · lore
For consistency with the rest of the test files.
Signed-off-by: Mark Rada <marada@uwaterloo.ca>
---
	No changes, just a resend. This should work; I assume
	the problem last time was a human error (me :(), or
	something weird that happens with saving e-mail drafts
	between	Apple Mail and Thunderbird (they share).
	If this version is also messed up, then I give up.
	Jeff, please explain what you meant by `inscrutable
	binary'? It is an ASCII text file according to file.
	¯\(°_o)/¯
 0 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 t/t5531-deep-submodule-push.sh
 mode change 100644 => 100755 t/t9501-gitweb-standalone-http-status.sh
Show changes to 2 files +0 −1

t/t5531-deep-submodule-push.sh, t/t9501-gitweb-standalone-http-status.sh

diff --git a/t/t5531-deep-submodule-push.sh b/t/t5531-deep-submodule-push.sh
old mode 100644
new mode 100755
diff --git a/t/t9501-gitweb-standalone-http-status.sh b/t/t9501-gitweb-standalone-http-status.sh
old mode 100644
new mode 100755
--
1.6.5.rc2
Jeff King· Oct 6, 2009, 10:00 UTC · re: Mark Rada · lore

Re: [PATCH] tests: make all test files executable

On Mon, Oct 05, 2009 at 09:46:06PM -0400, Mark Rada wrote:
> 	No changes, just a resend. This should work; I assume
> 	the problem last time was a human error (me :(), or
> 	something weird that happens with saving e-mail drafts
> 	between	Apple Mail and Thunderbird (they share).

This version looks fine (though I fixed up and applied the old one, so it is only useful as an experment). Whatever you did differently worked. :)

> 	Jeff, please explain what you meant by `inscrutable
> 	binary'? It is an ASCII text file according to file.
> 	¯\(°_o)/¯

When I looked at in mutt, it was full of binary garbage. But looking at it more closely, the attachment is bogus. Look at:

  http://article.gmane.org/gmane.comp.version-control.git/129522/raw

You have a message/rfc822 attachment which claims to be encoded using base64. But there's a bunch of extra text at the top before the base64 starts, which throws off the decoding, leading to the binary garbage.

So the .eml format appears to be a subset of the headers, followed by the base64-encoded body. But your mail client, in attaching it, marked it as base64-encoded, which is just wrong. But in theory that is a problem in transporting the file to the list. For you to "git am" it yourself, we'll assume you saw the raw contents.

Even then, it is still a confusing format. Instead of the headers looking like

  From: whatever
there is a line break, so they appear as
  From:
  whatever

and of course there are no mime headers indicating that body is base64-encoded. So it is definitely not an rfc822 message, which is what "git am" is expecting.

-Peff

← back to recent threads