Re: Interim maintainer tree

From: Jeff King <peff@peff.net>
Date: Oct 4, 2009, 13:29 UTC
Message-ID: <20091004132936.GA13804@sigill.intra.peff.net>
In-Reply-To: <7viqevpjr3.fsf@alter.siamese.dyndns.org>

On Sun, Oct 04, 2009 at 02:54:08AM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> >   - silence gcc warning:
> >     http://article.gmane.org/gmane.comp.version-control.git/129485
> >     The warning is overly cautious, I think, but it is a dubious enough
> >     construct that it is probably worth fixing.
> 
> I cannot reach gmane now, but if this is about -Wextra, I'd rather not
> touch it before the release.  "comparison between signed and unsigned"
> tends to be excessive and IMNSHO it is crazy to use -Wextra and -Werror 
> together.

Actually, I mislabeled this. It is about a glibc run-time complaint not a gcc warning, which is more worrisome. It is triggered by an argv list where we pass (argv - 1) to something expecting only to index it starting from '1'. I'm not sure yet if it is glibc being picky or if we violate that assumption somewhere. I'll post a followup in the thread.

-Peff