Re: [PATCH] git-am: force egrep to use correct characters set

From: Christian Himpel <chressie@googlemail.com>
Date: Sep 28, 2009, 06:55 UTC
Message-ID: <20090928065519.GA24773@lamagra.informatik.uni-ulm.de>
In-Reply-To: <20090927074015.GB15393@coredump.intra.peff.net>

On Sun, Sep 27, 2009 at 03:40:15AM -0400, Jeff King wrote:

Show 16 quoted lines

> On Fri, Sep 25, 2009 at 06:43:20PM +0200, Christian Himpel wrote:
> 
> > According to egrep(1) the US-ASCII table is used when LC_ALL=C is set.
> > We do not rely here on the LC_ALL value we get from the environment.
> 
> Hmm. Probably makes sense here, as it is a wide enough range that it may
> pick up other stray non-ascii characters in other charsets (though as
> the manpage notes, the likely thing is to pick up A-Z along with a-z,
> which is OK here as we encompass both in our range).
> 
> There are two other calls to egrep with brackets (both in
> git-submodule.sh), but they are just [0-7], which is presumably OK in
> just about any charset.
> 
> Do you happen to know a charset in which this is a problem, just for
> reference?

No, I don't know any charset with stray ascii-chars. I just listened attentively, when I read the part about the mixed alphabet characters in the grep(1) manpage.

I did some quick checks just now. It seems the characters (' ' to '~') are in any locale, offered by glibc, at the same place.

Maybe, we can just leave the charset as it is and ignore this patch, until someone complains.

Regards, chressie

> 
> -Peff