git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-am: force egrep to use correct characters set

From
Jeff King <peff@peff.net>
Date
Sep 27, 2009, 07:40 UTC
Message-ID
<20090927074015.GB15393@coredump.intra.peff.net>
In-Reply-To
<f0bd48168975c3b2328cf26f9a37a0f54b898473.1253896646.git.chressie@gmail.com>
On Fri, Sep 25, 2009 at 06:43:20PM +0200, Christian Himpel wrote:
> According to egrep(1) the US-ASCII table is used when LC_ALL=C is set.
> We do not rely here on the LC_ALL value we get from the environment.

Hmm. Probably makes sense here, as it is a wide enough range that it may pick up other stray non-ascii characters in other charsets (though as the manpage notes, the likely thing is to pick up A-Z along with a-z, which is OK here as we encompass both in our range).

There are two other calls to egrep with brackets (both in git-submodule.sh), but they are just [0-7], which is presumably OK in just about any charset.

Do you happen to know a charset in which this is a problem, just for reference?

-Peff
Previous: Christian HimpelNext: Christian Himpel
Message 5 of 11 in “git-am: fixed patch_format detection according to RFC2822”
  1. 1/2 git-am: fixed patch_format detection according to RFC2822Christian Himpel, Sep 25, 2009
  2. 2/2 git-am: force egrep to use correct characters setChristian Himpel, Sep 25, 2009
  3. 2/2 git-am: force egrep to use correct characters setChristian Himpel, Sep 25, 2009
  4. git-am: force egrep to use correct characters setChristian Himpel, Sep 25, 2009
  5. Jeff KingSep 27, 2009
  6. Christian HimpelSep 28, 2009
  7. Jeff KingSep 28, 2009
  8. Johannes SixtSep 28, 2009
  9. Christian HimpelSep 28, 2009
  10. Johannes SixtSep 28, 2009
  11. Christian HimpelSep 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.