Re: [PATCH] reflog documentation: -n is an alias for --dry-run

From: Nelson Elhage <nelhage@mit.edu>
Date: Sep 13, 2009, 12:53 UTC
Message-ID: <20090913125313.GQ4275@mit.edu>
In-Reply-To: <20090913094032.GC14438@coredump.intra.peff.net>

Oh, I see. I was reading builtin-reflog.c, which, in both cmd_reflog_expire and cmd_reflog_delete, does check for -n as synonymous to --dry-run:

if (!strcmp(arg, "--dry-run") || !strcmp(arg, "-n"))
    cb.dry_run = 1;

but I missed that 'reflog show' aliases for git-log, and that that accepts -n.

Patch withdrawn -- I'd send one documenting that -n works for delete and expire, but it'd probably just complicate the documentation more than clarify anything.

- Nelson

On Sun, Sep 13, 2009 at 05:40:32AM -0400, Jeff King wrote:

Show 9 quoted lines

> On Sat, Sep 12, 2009 at 11:41:54PM -0400, Nelson Elhage wrote:
> 
> >  static const char reflog_expire_usage[] =
> > -"git reflog (show|expire) [--verbose] [--dry-run] [--stale-fix] [--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>...";
> > +"git reflog (show|expire) [--verbose] [-n | --dry-run] [--stale-fix] [--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>...";
> 
> Really? I think "git reflog show -n" is not about dry-run at all...
> 
> -Peff