threads / patch / 20924

patchreflog documentation: -n is an alias for --dry-run

Subject: [PATCH] reflog documentation: -n is an alias for --dry-run

## tl;dr

5 messages between Sep 13, 2009 and Sep 13, 2009. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Nelson Elhage· Sep 13, 2009, 03:41 UTC · lore
Signed-off-by: Nelson Elhage <nelhage@mit.edu>
---
 Documentation/git-reflog.txt |    2 +-
 builtin-reflog.c             |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Show changes to 2 files +3 −3

Documentation/git-reflog.txt, builtin-reflog.c

diff --git a/Documentation/git-reflog.txt b/Documentation/git-reflog.txt
index 7f7a544..b434ff7 100644
--- a/Documentation/git-reflog.txt
+++ b/Documentation/git-reflog.txt
@@ -16,7 +16,7 @@ The command takes various subcommands, and different options
 depending on the subcommand:
 
 [verse]
-'git reflog expire' [--dry-run] [--stale-fix] [--verbose]
+'git reflog expire' [-n | --dry-run] [--stale-fix] [--verbose]
 	[--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>...
 +
 'git reflog delete' ref@\{specifier\}...
diff --git a/builtin-reflog.c b/builtin-reflog.c
index 95198c5..f37c57b 100644
--- a/builtin-reflog.c
+++ b/builtin-reflog.c
@@ -13,9 +13,9 @@
  */
 
 static const char reflog_expire_usage[] =
-"git reflog (show|expire) [--verbose] [--dry-run] [--stale-fix] [--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>...";
+"git reflog (show|expire) [--verbose] [-n | --dry-run] [--stale-fix] [--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>...";
 static const char reflog_delete_usage[] =
-"git reflog delete [--verbose] [--dry-run] [--rewrite] [--updateref] <refs>...";
+"git reflog delete [--verbose] [-n | --dry-run] [--rewrite] [--updateref] <refs>...";
 
 static unsigned long default_reflog_expire;
 static unsigned long default_reflog_expire_unreachable;

-- 
1.6.3.1.499.ge7b8da
Jeff King· Sep 13, 2009, 09:40 UTC · re: Nelson Elhage · lore

Re: [PATCH] reflog documentation: -n is an alias for --dry-run

On Sat, Sep 12, 2009 at 11:41:54PM -0400, Nelson Elhage wrote:
>  static const char reflog_expire_usage[] =
> -"git reflog (show|expire) [--verbose] [--dry-run] [--stale-fix] [--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>...";
> +"git reflog (show|expire) [--verbose] [-n | --dry-run] [--stale-fix] [--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>...";
Really? I think "git reflog show -n" is not about dry-run at all...
-Peff
Nelson Elhage· Sep 13, 2009, 12:53 UTC · re: Jeff King · lore

Re: [PATCH] reflog documentation: -n is an alias for --dry-run

Oh, I see. I was reading builtin-reflog.c, which, in both cmd_reflog_expire and cmd_reflog_delete, does check for -n as synonymous to --dry-run:

if (!strcmp(arg, "--dry-run") || !strcmp(arg, "-n"))
    cb.dry_run = 1;

but I missed that 'reflog show' aliases for git-log, and that that accepts -n.

Patch withdrawn -- I'd send one documenting that -n works for delete and expire, but it'd probably just complicate the documentation more than clarify anything.

- Nelson
On Sun, Sep 13, 2009 at 05:40:32AM -0400, Jeff King wrote:
Show 9 quoted lines
> On Sat, Sep 12, 2009 at 11:41:54PM -0400, Nelson Elhage wrote:
> 
> >  static const char reflog_expire_usage[] =
> > -"git reflog (show|expire) [--verbose] [--dry-run] [--stale-fix] [--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>...";
> > +"git reflog (show|expire) [--verbose] [-n | --dry-run] [--stale-fix] [--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>...";
> 
> Really? I think "git reflog show -n" is not about dry-run at all...
> 
> -Peff
Jeff King· Sep 13, 2009, 13:26 UTC · re: Nelson Elhage · lore

Re: [PATCH] reflog documentation: -n is an alias for --dry-run

On Sun, Sep 13, 2009 at 08:53:13AM -0400, Nelson Elhage wrote:
> Patch withdrawn -- I'd send one documenting that -n works for delete
> and expire, but it'd probably just complicate the documentation more
> than clarify anything.

I think it would be fine to just split the (show|expire) line into two separate lines:

> > > -"git reflog (show|expire) [--verbose] [--dry-run] [--stale-fix] [--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>...";
> > > +"git reflog (show|expire) [--verbose] [-n | --dry-run] [--stale-fix] [--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>...";
-Peff
Erik Faye-Lund· Sep 13, 2009, 13:05 UTC · re: Jeff King · lore

Re: [PATCH] reflog documentation: -n is an alias for --dry-run

On Sun, Sep 13, 2009 at 11:40 AM, Jeff King <peff@peff.net> wrote:
Show 5 quoted lines
>>  static const char reflog_expire_usage[] =
>> -"git reflog (show|expire) [--verbose] [--dry-run] [--stale-fix] [--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>...";
>> +"git reflog (show|expire) [--verbose] [-n | --dry-run] [--stale-fix] [--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>...";
>
> Really? I think "git reflog show -n" is not about dry-run at all...

Indeed. However, the reflog expire uses -n as an alias for --dry-run, according to lines 548-549 of my builtin-reflog.c (ddfdf5a):

		if (!strcmp(arg, "--dry-run") || !strcmp(arg, "-n"))
			cb.dry_run = 1;

...and this usage-string is only output from cmd_reflog_expire, so the correct solution would IMO be to simply remove show from the usage-string:

-"git reflog (show|expire) [--verbose] [-n | --dry-run] [--stale-fix] [--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>..."; +"git reflog expire [--verbose] [-n | --dry-run] [--stale-fix] [--expire=<time>] [--expire-unreachable=<time>] [--all] <refs>...";

This issue ("reflog expire" incorrectly documenting "reflog show") was present before this patch, though. At least the option "--stale-fix" appears not to be valid for "reflog show".

-- 
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656

← back to recent threads