git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 5/9] revert: libify pick

From
Christian Couder <chriscool@tuxfamily.org>
Date
Aug 22, 2009, 04:35 UTC
Message-ID
<200908220635.56925.chriscool@tuxfamily.org>
In-Reply-To
<7v8whdip1l.fsf@alter.siamese.dyndns.org>
On Friday 21 August 2009, Junio C Hamano wrote:
Show 16 quoted lines
> Christian Couder <chriscool@tuxfamily.org> writes:
> > From: Stephan Beyer <s-beyer@gmx.net>
> >
> > This commit is made of code from the sequencer GSoC project:
> >
> > git://repo.or.cz/git/sbeyer.git
> >
> > (commit 5a78908b70ceb5a4ea9fd4b82f07ceba1f019079)
> >
> > The goal of this commit is to abstract out pick functionnality
> > into a new pick() function made of code from "builtin-revert.c".
> >
> > The new pick() function is in a new "pick.c" file with an
> > associated "pick.h".
>
> Is it pick() or pick_commit()?
It is pick_commit(). Sorry I didn't properly update the commit message.
> By the way, this comment applies to other messages in the series, but do
> these original commits by Stephan lack any meaningful messages?

Well, in Stephan's repo the commit (94a568a78d243d7a6c13778bc6b7ac1eb46e48cc) that created the pick.c and pick.h files had this message:

------ Libify cherry-pick and revert.

A poor start. ------

(Note that I have seen far worse commit messages in other GSoC students' repo.) And then quite a few other commits improved on this one, and the whole gives the code that is in this patch.

Show 18 quoted lines
> I would 
> actually have expected to see a commit log message that looks more like:
>
> 	From: Stephan Beyer <...>
>
>         Meaningful log message Stephan describes what this commit does in
>         sufficient detail, perhaps with clarification and rewording by
>         Christian.
>
> 	Second and subsequent paragraph to explain it as necessary.
>
> 	[cc: this is based on 5a78908b70ceb5a4ea9fd4b82f07ceba1f019079
>         from Stephan's git://repo.or.cz/git/sbeyer.git]
>
>         Signed-off-by: ...
>
> The point is that the "origin info" would be a side-note, not the first
> and the most important thing in the message.

I tried to improve some commit messages like this in the v3 that will follow this email.

Thanks, Christian.

Previous: Junio C HamanoNext: Christian Couder
Message 8 of 12 in “more changes to port rebase -i to C using sequencer code”
  1. 0/9 more changes to port rebase -i to C using sequencer codeChristian Couder, Aug 21, 2009
  2. 1/9 sequencer: add "do_fast_forward()" to perform a fast forwardChristian Couder, Aug 21, 2009
  3. 2/9 sequencer: add "--fast-forward" option to "git sequencer--helper"Christian Couder, Aug 21, 2009
  4. 3/9 sequencer: let "git sequencer--helper" callers set "allow_dirty"Christian Couder, Aug 21, 2009
  5. 4/9 rebase -i: use "git sequencer--helper --fast-forward"Christian Couder, Aug 21, 2009
  6. 5/9 revert: libify pickChristian Couder, Aug 21, 2009
  7. Junio C HamanoAug 21, 2009
  8. Christian CouderAug 22, 2009
  9. 6/9 pick: libify "pick_help_msg()"Christian Couder, Aug 21, 2009
  10. 7/9 sequencer: add "do_commit()" and related functionsChristian Couder, Aug 21, 2009
  11. 8/9 sequencer: add "--cherry-pick" option to "git sequencer--helper"Christian Couder, Aug 21, 2009
  12. 9/9 rebase -i: use "git sequencer--helper --cherry-pick"Christian Couder, Aug 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.