git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 4/9] rebase -i: use "git sequencer--helper --fast-forward"

From
Christian Couder <chriscool@tuxfamily.org>
Date
Aug 21, 2009, 05:49 UTC
Message-ID
<20090821055001.3726.90621.chriscool@tuxfamily.org>
In-Reply-To
<20090821054729.3726.5078.chriscool@tuxfamily.org>
when fast forwarding.
Note that in the first hunk of this patch, there was this line:
test "a$1" = a-n && output git reset --soft $current_sha1
but the test always failed.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 git-rebase--interactive.sh |   11 +++--------
 1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 0041994..7651fd6 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -154,11 +154,8 @@ pick_one () {
 		die "Could not get the parent of $sha1"
 	current_sha1=$(git rev-parse --verify HEAD)
 	if test "$no_ff$current_sha1" = "$parent_sha1"; then
-		git sequencer--helper --reset-hard $sha1 \
+		git sequencer--helper --fast-forward $sha1 \
 			"$GIT_REFLOG_ACTION" "$VERBOSE"
-		test "a$1" = a-n && output git reset --soft $current_sha1
-		sha1=$(git rev-parse --short $sha1)
-		output warn Fast forward to $sha1
 	else
 		output git cherry-pick "$@"
 	fi
@@ -238,10 +235,8 @@ pick_one_preserving_merges () {
 	done
 	case $fast_forward in
 	t)
-		output warn "Fast forward to $sha1"
-		git sequencer--helper --reset-hard $sha1 \
-			"$GIT_REFLOG_ACTION" "$VERBOSE" ||
-			die "Cannot fast forward to $sha1"
+		git sequencer--helper --fast-forward $sha1 \
+			"$GIT_REFLOG_ACTION" "$VERBOSE" || exit
 		;;
 	f)
 		first_parent=$(expr "$new_parents" : ' \([^ ]*\)')
-- 
1.6.4.271.ge010d
Previous: Christian CouderNext: Christian Couder
Message 5 of 12 in “more changes to port rebase -i to C using sequencer code”
  1. 0/9 more changes to port rebase -i to C using sequencer codeChristian Couder, Aug 21, 2009
  2. 1/9 sequencer: add "do_fast_forward()" to perform a fast forwardChristian Couder, Aug 21, 2009
  3. 2/9 sequencer: add "--fast-forward" option to "git sequencer--helper"Christian Couder, Aug 21, 2009
  4. 3/9 sequencer: let "git sequencer--helper" callers set "allow_dirty"Christian Couder, Aug 21, 2009
  5. 4/9 rebase -i: use "git sequencer--helper --fast-forward"Christian Couder, Aug 21, 2009
  6. 5/9 revert: libify pickChristian Couder, Aug 21, 2009
  7. Junio C HamanoAug 21, 2009
  8. Christian CouderAug 22, 2009
  9. 6/9 pick: libify "pick_help_msg()"Christian Couder, Aug 21, 2009
  10. 7/9 sequencer: add "do_commit()" and related functionsChristian Couder, Aug 21, 2009
  11. 8/9 sequencer: add "--cherry-pick" option to "git sequencer--helper"Christian Couder, Aug 21, 2009
  12. 9/9 rebase -i: use "git sequencer--helper --cherry-pick"Christian Couder, Aug 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.