Re: [EGIT PATCH] Provide a more JavaBeans-style 'getName' accessor for the id Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>

From: Shawn O. Pearce <spearce@spearce.org>
Date: Aug 10, 2009, 15:52 UTC
Message-ID: <20090810155207.GW1033@spearce.org>
In-Reply-To: <1241909854-11498-1-git-send-email-alex.blewitt@gmail.com>

Alex Blewitt <alex.blewitt@gmail.com> wrote:

Show 17 quoted lines

> ---
>  .../src/org/spearce/jgit/lib/AnyObjectId.java      |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java b/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java
> index acb3cb5..015042a 100644
> --- a/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java
> +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java
> @@ -448,6 +448,12 @@ public final String name() {
>  	}
>  
>  	/**
> +	 * @return string form of the SHA-1, in lower case hexadecimal.
> +	 */
> +	public final String getName() {
> +		return name();
> +	}

Obviously you didn't compile test this in JGit:

./org/spearce/jgit/revwalk/RevTag.java:206: getName() in org.spearce.jgit.revwalk.RevTag cannot override getName() in org.spearce.jgit.lib.AnyObjectId; overridden method is final

:-(

-- 
Shawn.