git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 4/5] pick: remove useless PICK_REVERSE => PICK_ADD_NOTE code

From
Christian Couder <chriscool@tuxfamily.org>
Date
Aug 1, 2009, 15:46 UTC
Message-ID
<20090801154607.20922.74121.chriscool@tuxfamily.org>
Junio noticed that the removed code was useless.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 pick.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/pick.c b/pick.c
index 13bf793..a6b1d6f 100644
--- a/pick.c
+++ b/pick.c
@@ -84,9 +84,6 @@ int pick_commit(struct commit *pick_commit, int mainline, int flags,
 	strbuf_init(msg, 0);
 	commit = pick_commit;
 
-	if (flags & PICK_REVERSE) /* REVERSE implies ADD_NOTE */
-		flags |= PICK_ADD_NOTE;
-
 	/*
 	 * We do not intend to commit immediately.  We just want to
 	 * merge the differences in, so let's compute the tree
-- 
1.6.4.133.g8a5c8
Message 1 of 1 in “pick: remove useless PICK_REVERSE => PICK_ADD_NOTE code”
  1. 4/5 pick: remove useless PICK_REVERSE => PICK_ADD_NOTE codeChristian Couder, Aug 1, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.