threads / patch / 20330

v2, 5 partspick: remove useless PICK_REVERSE => PICK_ADD_NOTE code

Subject: [PATCH v2 4/5] pick: remove useless PICK_REVERSE => PICK_ADD_NOTE code

## tl;dr

One message between Aug 1, 2009 and Aug 1, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Christian Couder· Aug 1, 2009, 15:46 UTC · lore
Junio noticed that the removed code was useless.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 pick.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
Show changes to pick.c +0 −3
diff --git a/pick.c b/pick.c
index 13bf793..a6b1d6f 100644
--- a/pick.c
+++ b/pick.c
@@ -84,9 +84,6 @@ int pick_commit(struct commit *pick_commit, int mainline, int flags,
 	strbuf_init(msg, 0);
 	commit = pick_commit;
 
-	if (flags & PICK_REVERSE) /* REVERSE implies ADD_NOTE */
-		flags |= PICK_ADD_NOTE;
-
 	/*
 	 * We do not intend to commit immediately.  We just want to
 	 * merge the differences in, so let's compute the tree
-- 
1.6.4.133.g8a5c8

← back to recent threads