git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: suppress 'Use of uninitialized value' error

From
Jakub Narebski <jnareb@gmail.com>
Date
Jul 31, 2009, 06:24 UTC
Message-ID
<200907310824.42953.jnareb@gmail.com>
In-Reply-To
<cb7bb73a0907302306k691b1d4fy85d7b460077bc639@mail.gmail.com>
Giuseppe Bilotta wrote:
> 2009/7/31 Jakub Narebski <jnareb@gmail.com>:
Show 5 quoted lines
> > I don't think gitweb generates such
> > broken links (with 'hash_parent_base' but not 'file_parent') normally,
> > but I might be mistaken.
> 
> Do you think it would be worth to protect against this case?

Yes, of course it is worth protecting against this case (better checking if both sides of 'eq' comparison are defined). We want to return error message from gitweb if URL is borked, not have Perl error in logs.

-- 
Jakub Narebski
Poland
Previous: Giuseppe BilottaNext: Giuseppe Bilotta
Message 4 of 9 in “gitweb: suppress 'Use of uninitialized value' error”
  1. gitweb: suppress 'Use of uninitialized value' errorGiuseppe Bilotta, Jul 30, 2009
  2. Jakub NarebskiJul 30, 2009
  3. Giuseppe BilottaJul 31, 2009
  4. Jakub NarebskiJul 31, 2009
  5. gitweb: fix 'Use of uninitialized value' error in href()Giuseppe Bilotta, Jul 31, 2009
  6. Jakub NarebskiJul 31, 2009
  7. Giuseppe BilottaJul 31, 2009
  8. Junio C HamanoJul 31, 2009
  9. Junio C HamanoAug 4, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.