From: Jakub Narebski <jnareb@gmail.com>
Date: Fri, 31 Jul 2009 06:24:41 GMT
Subject: Re: [PATCH] gitweb: suppress 'Use of uninitialized value' error
Message-ID: <200907310824.42953.jnareb@gmail.com>
In-Reply-To: <cb7bb73a0907302306k691b1d4fy85d7b460077bc639@mail.gmail.com>

Giuseppe Bilotta wrote:
> 2009/7/31 Jakub Narebski <jnareb@gmail.com>:

> > I don't think gitweb generates such
> > broken links (with 'hash_parent_base' but not 'file_parent') normally,
> > but I might be mistaken.
> 
> Do you think it would be worth to protect against this case?

Yes, of course it is worth protecting against this case (better checking
if both sides of 'eq' comparison are defined).  We want to return error
message from gitweb if URL is borked, not have Perl error in logs.

-- 
Jakub Narebski
Poland