Re: [PATCH] Add git svn gc command

From: Eric Wong <normalperson@yhbt.net>
Date: Jul 21, 2009, 03:25 UTC
Message-ID: <20090721032515.GA4636@dcvr.yhbt.net>
In-Reply-To: <1030C457-44CB-4D78-A692-8F3B34A3E9BD@gmail.com>

Robert Zeh <robert.a.zeh@gmail.com> wrote:

Show 5 quoted lines

> Hi Eric,
>
> Thanks for all of the suggestions.  I've attached a patch that takes all 
> of the list suggestions into account.  I hope I've implemented the  
> can_compress changes properly.

Hi Robert, that looks fine to me.

> I believe I've fixed the white space issues; I tried a round trip and my 
> tabs were preserved.  The getcwd stuff was indeed leftover code from 
> testing; I found another left over debug statement.

The tabs seem alright, but spaces are still mangled. Perhaps Documentation/SubmittingPatches has tips for your mailer? (or check out git send-email)

> I have one remaining question ---  does git svn gc need to avoid  
> removing index files if --no-metadata was set?  If it does, I'd  
> appreciate a tip on how to see if it was set.

Nope, not at all, index files are very safely removable unless there's a clone/fetch actively running. The rev_map files on the other hand are not removable iff --no-metadata or --use-svm-props is used.

-- 
Eric Wong