Re: [PATCH] Add git svn gc command

From: Eric Wong <normalperson@yhbt.net>
Date: Jul 20, 2009, 08:36 UTC
Message-ID: <20090720083621.GA3237@dcvr.yhbt.net>
In-Reply-To: <9b18b3110907200115p4c0c3b45nc6c7f31b34ceff0c@mail.gmail.com>

demerphq <demerphq@gmail.com> wrote:

Show 15 quoted lines

> 2009/7/20 Eric Wong <normalperson@yhbt.net>:
> > Robert Zeh <robert.a.zeh@gmail.com> wrote:
> >> --- a/git-svn.perl
> >> +++ b/git-svn.perl
> >> @@ -35,11 +35,14 @@ push @Git::SVN::Ra::ISA, 'SVN::Ra';
> >>  push @SVN::Git::Editor::ISA, 'SVN::Delta::Editor';
> >>  push @SVN::Git::Fetcher::ISA, 'SVN::Delta::Editor';
> >>  use Carp qw/croak/;
> >> +use Compress::Zlib;
> >
> > I'd "require" Compress::Zlib lazilly so it's not loaded at startup.
> > It's not a stock component of Perl and not needed for the majority of
> > commands.
> 
> Actually, it has been a core component since 5.9.3

Ah thanks for pointing that out, I didn't notice my 5.10.x install had it. Nevertheless, git svn needs to continue supporting 5.8.x for a while longer.

-- 
Eric Wong