Re: [PATCH] Fix export_marks() error handling.

From: Stephen R. van den Berg <srb@cuci.nl>
Date: Jul 11, 2009, 09:45 UTC
Message-ID: <20090711094546.GA12399@cuci.nl>
In-Reply-To: <1247146081-4692-1-git-send-email-matthias.andree@gmx.de>

Matthias Andree wrote:

Show 8 quoted lines

>+	/* do not optimize the next two lines - they must both be executed in
>+	 * this order. || might short-circuit the fclose(), and combining them
>+	 * into one statement might reverse the order of execution.
>+	 * Also, fflush() may not be sufficient - on some file systems, the
>+	 * error is still delayed until the final [f]close().  */
>+	e  = ferror(f);
>+	e |= fclose(f);
>+	if (e)

The commentary above should be common knowledge for anyone familiar with ANSI C. So I'd suggest moving the comments into the description section of the commit and removing them from the actual code.

-- 
Sincerely,
           Stephen R. van den Berg.

"And now for something *completely* different!"