Re: found a resource leak in file builtin-fast-export.c
- From
Thomas Rast <trast@student.ethz.ch>
- Date
- Jul 9, 2009, 08:31 UTC
- Message-ID
- <200907091031.43494.trast@student.ethz.ch>
- In-Reply-To
- <20090709075728.137880@gmx.net>
Hi Martin
Martin Ettl wrote:
> > I have attached a patch to resolve this.
Please read Documentation/SubmittingPatches in the source tree. And use git to track git.git!
As for the actual patch:
Show 10 quoted lines
> --- git-1.6.3.3/builtin-fast-export.c 2009-06-22 08:24:25.000000000 +0200
> +++ git-1.6.3.3/builtin-fast-export_new.c 2009-07-09 09:44:28.000000000 +0200
> @@ -442,8 +442,9 @@ static void export_marks(char *file)
> deco++;
> }
>
> - if (ferror(f) || fclose(f))
> + if (ferror(f))
> error("Unable to write marks file %s.", file);
> + fclose(f);You no longer check the error returned by fclose(). This is important, because the FILE* API may buffer writes, and a write error may only become apparent when fclose() flushes the file.
> } > > static void import_marks(char *input_file)
--
Thomas Rast
trast@{inf,student}.ethz.ch