git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH] Support for delegating tree iterators

From
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date
Jul 2, 2009, 20:00 UTC
Message-ID
<200907022200.40179.robin.rosenberg.lists@dewire.com>
In-Reply-To
<1246470772-4496-1-git-send-email-constantine.plotnikov@gmail.com>
onsdag 01 juli 2009 19:52:52 skrev Constantine Plotnikov <constantine.plotnikov@gmail.com>:
Show 12 quoted lines
> +	protected void ensurePathCapacity(final int capacity, final int len) {
> +		if(path.length >= capacity) {
> +			return;
> +		}
> +		final byte[] o = path;
> +		int current = o.length;
> +		int newCapacity = current;
> +		while(newCapacity < capacity && newCapacity > 0) {
> +			newCapacity <<= 1;
> +		}
> +		setPathCapacity(newCapacity, len);
> +	}

There are no JUnit tests that directly or indirectly proves this is working as only the optimized path is taken.

> +	public int getNameLength() {
> +		return pathLen - pathOffset;
> +	}
> +	public void getName(byte[] buffer, int offset) {
> +		System.arraycopy(path, pathOffset, buffer, offset, pathLen - pathOffset);
> +	}
Never used? Not even unit test code.
> -- robin
Previous: Shawn O. Pearce
Message 4 of 4 in “Support for delegating tree iterators”
  1. Support for delegating tree iteratorsConstantine Plotnikov, Jul 1, 2009
  2. Shawn O. PearceJul 1, 2009
  3. Shawn O. PearceJul 1, 2009
  4. Robin RosenbergJul 2, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.