Re: [JGIT PATCH] Support for delegating tree iterators

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jul 1, 2009, 22:41 UTC
Message-ID: <20090701224137.GU11191@spearce.org>
In-Reply-To: <20090701223448.GT11191@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> wrote:

Show 11 quoted lines

> Constantine Plotnikov <constantine.plotnikov@gmail.com> wrote:
> > This patch introduce some methods that simplify creation of tree
> > iterators that wraps other iterators and which are located in
> > other package. Such iterators need to efficiently access the
> > name component of the path of wrapped iterator and wrapped bits.
> > The patch also adds a method that ensuring that path buffer has
> > a requried capacity when the required capacity is known in advance.
> > 
> > Signed-off-by: Constantine Plotnikov <constantine.plotnikov@gmail.com>
> 
> Thanks, two style nits, I fixed during apply:

I also decided to squash this in, the name better matches with TreeWalk's other like methods. That is, the method name in TreeWalk lacks the "Entry" prefix, but is otherwise the same name as the name in the iterator.

diff --git a/org.spearce.jgit/src/org/spearce/jgit/treewalk/AbstractTreeIterator.java b/org.spearce.jgit/src/org/spearce/jgit/treewalk/AbstractTreeIterator.java
index 50befbe..2116387 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/treewalk/AbstractTreeIterator.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/treewalk/AbstractTreeIterator.java
@@ -387,7 +387,7 @@ public FileMode getEntryFileMode() {
 	}
 
 	/** @return the file mode of the current entry as bits */
-	public int getEntryFileModeBits() {
+	public int getEntryRawMode() {
 		return mode;
 	}

-- 
Shawn.