Re: [PATCH 1/2] git-send-email.perl: Don't add header "In-Reply-To:" when --no-chain-reply-to set

From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Jul 1, 2009, 16:59 UTC
Message-ID: <200907011900.00131.markus.heidelberg@web.de>
In-Reply-To: <1246429653.6259.111.camel@Joe-Laptop.home>

Joe Perches, 01.07.2009:

Show 10 quoted lines

> On Wed, 2009-07-01 at 08:18 +0200, Markus Heidelberg wrote:
> > Joe Perches, 01.07.2009:
> > > using
> > >   git format-patch --thread=shallow -o <foo>
> > > and
> > >   git send-email --no-thread --no-chain-reply-to <foo>
> > 
> > I guess you meant --thread here.
> 
> Actually, I did mean --no-thread.

But --no-thread doesn't duplicate, --thread does.

According to the last line of your patch, you are using an old version 1.6.3.1. After this version two threading bugs were fixed, so you may encounter a wrong behaviour with your old version.

> If format-patch does the threading, send-email shouldn't.

If the user wants format-patch to do the threading, he shouldn't want send-email to do it as well.

Markus