Re: [PATCH 1/2] git-send-email.perl: Don't add header "In-Reply-To:" when --no-chain-reply-to set

From: Joe Perches <joe@perches.com>
Date: Jul 1, 2009, 06:27 UTC
Message-ID: <1246429653.6259.111.camel@Joe-Laptop.home>
In-Reply-To: <200907010818.57050.markus.heidelberg@web.de>

On Wed, 2009-07-01 at 08:18 +0200, Markus Heidelberg wrote:

Show 7 quoted lines

> Joe Perches, 01.07.2009:
> > using
> >   git format-patch --thread=shallow -o <foo>
> > and
> >   git send-email --no-thread --no-chain-reply-to <foo>
> 
> I guess you meant --thread here.

Actually, I did mean --no-thread. If format-patch does the threading, send-email shouldn't.

Show 18 quoted lines

> > duplicates the headers
> > 
> >   In-Reply-To:
> >   References:
> 
> You should run at least the test from the test suite for the particular
> command you change. Test 49 (threading but no chain-reply-to) from t9001
> now fails.
> 
> That means, this will fail now (covered by test 49):
> 
>   git format-patch -o <foo>
>   git send-email --thread --no-chain-reply-to <foo>
> 
> and also this (not covered by any test, maybe we should add one):
> 
>   git format-patch -o <foo>
>   git send-email --thread --chain-reply-to <foo>

I didn't know the tests existed, thanks. I'll investigate a bit more.

cheers, Joe