Re: [PATCH QGit RFC] Fix "Save patch..." on a commit range

From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Jun 13, 2009, 11:33 UTC
Message-ID: <200906131333.57725.markus.heidelberg@web.de>
In-Reply-To: <e5bfff550906130412v6e223511tf0e20c685b21c490@mail.gmail.com>

Marco Costalba, 13.06.2009:

Show 13 quoted lines

> On Sat, Jun 13, 2009 at 12:02, Markus
> Heidelberg<markus.heidelberg@web.de> wrote:
> >
> > OK, if I now disable "All branches" in "View->Select range...", I get
> > the 2 patches from above again.
> > But in my git repo with local branches, it's the other way round...
> >
> > Markus
> >
> 
> Ok. The point is that if I select 4 _consecutive_ revisions from any
> repo and do "Save as..." then I see the 4 patches created in reverse
> cronoligical order as it should be.

I did the same as you: selected the 4 consecutive revisions. But I didn't get 4 patches. Dependent on the state of the "All branches" checkbox of the "Range select", I get 2 or 0 patches. The QStringList shaList is set wrong for me.

> If I select only two patches _non_ consecutives and I do "Save as..."
> I get the two patches + all the pacthes in between still in reverse
> cronological order.

Yes, I'm aware of that. It shouldn't make a difference if I only select start end end revision or if I select all revisions including the revisions between start and end. And as I said earlier: the order of the patches is not my problem.

> This is with stock QGit 2.3, Windows version.

I tested with the latest qgit.git and with QGit 2.2 from my distribution. All on Gentoo Linux.

I just built QGit 2.3, this has the same problems.

> Have you some problem to reproduce this behavior (that is intended to
> be the correct one BTW) ?

Yes, I have :)

Can you please try, if enabling/disabling the "All branches" checkbox makes a difference for you?

I have few time this weekend to respond. Have to play a concert with my band today and clean my bike for a triathlon tomorrow. I will try to reproduce on Windows, probably after this weekend.

Thanks, Markus