Re: [PATCH QGit RFC] Fix "Save patch..." on a commit range

From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Jun 13, 2009, 11:02 UTC
Message-ID: <200906131302.43091.markus.heidelberg@web.de>
In-Reply-To: <e5bfff550906130013j3a9802cen48ac5828a2357bf1@mail.gmail.com>

Marco Costalba, 13.06.2009:

Show 23 quoted lines

> On Sat, Jun 13, 2009 at 00:29, Markus
> Heidelberg<markus.heidelberg@web.de> wrote:
> > Creating a patch series didn't work, because the SHA1 list was
> > interpreted in the wrong order.
> >
> > Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
> > ---
> 
> I think they are generated in apply order as should be.
> 
> As example, from git repo we have the following revisions:
> 
> GIT 1.6.3
> t4029: use sh instead of bash
> t4200: convert sed expression which operates on non-text file to perl
> t4200: remove two unnecessary lines
> 
> Now if I select the 4 revisions and use "Save patch..." I have
> 
> 0001-t4200-remove-two-unnecessary-lines.patch
> 0002-t4200-convert-sed-expression-which-operates-on-non.patch
> 0003-t4029-use-sh-instead-of-bash.patch
> 0004-GIT-1.6.3.patch

In my git repository with some local branches I get this:

0001-t4200-convert-sed-expression-which-operates-on-non-t.patch 0002-t4029-use-sh-instead-of-bash.patch

In a plain newly created git repo with this command:

git clone --reference git git://git.kernel.org/pub/scm/git/git.git git-orig

I don't get any patches. I haven't tried it explicitely now, but I guess my patch would solve this for me.

OK, if I now disable "All branches" in "View->Select range...", I get the 2 patches from above again. But in my git repo with local branches, it's the other way round...

Markus