git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 12/23] transport.c::get_refs_via_curl(): do not leak refs_url

From
Tay Ray Chuan <rctay89@gmail.com>
Date
Jun 6, 2009, 08:43 UTC
Message-ID
<20090606164340.a49e63ad.rctay89@gmail.com>
In-Reply-To
<cover.1244277116.git.rctay89@gmail.com>
From:	Mike Hommey <mh@glandium.org>
Signed-off-by: Mike Hommey <mh@glandium.org>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
This is based on Mike's earlier patch:
Subject: [WIP Patch 02/12] Some cleanup in get_refs_via_curl()
Date:   Sun, 18 Jan 2009 09:04:27 +0100

I've removed the http_cleanup() invocation, after Johannes reported that it breaks http clone. I've also renamed it, for clarity's sake.

 transport.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/transport.c b/transport.c
index efecb65..9edd5aa 100644
--- a/transport.c
+++ b/transport.c
@@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push)
 		free(ref);
 	}

+	free(refs_url);
 	return refs;
 }

--
1.6.3.1
Previous: Tay Ray ChuanNext: Tay Ray Chuan
Message 12 of 23 in “t5540-http-push: test fetching of loose objects”
  1. 01/23 t5540-http-push: test fetching of loose objectsTay Ray Chuan, Jun 6, 2009
  2. 02/23 t5540-http-push: test fetching of packed objectsTay Ray Chuan, Jun 6, 2009
  3. 03/23 http*: cleanup slot->local after fcloseTay Ray Chuan, Jun 6, 2009
  4. 04/23 http-push: send out fetch requests on queueTay Ray Chuan, Jun 6, 2009
  5. 05/23 http-push: fix missing "#ifdef USE_CURL_MULTI" around "is_running_queue"Tay Ray Chuan, Jun 6, 2009
  6. 06/23 t5550-http-fetch: test fetching of packed objectsTay Ray Chuan, Jun 6, 2009
  7. 07/23 http-push, http-walker: style fixesTay Ray Chuan, Jun 6, 2009
  8. 08/23 http-walker: verify remote packsTay Ray Chuan, Jun 6, 2009
  9. 09/23 http*: copy string returned by sha1_to_hexTay Ray Chuan, Jun 6, 2009
  10. 10/23 http-push: do not SEGV after fetching a bad pack idx fileTay Ray Chuan, Jun 6, 2009
  11. 11/23 Don't expect verify_pack() callers to set pack_sizeTay Ray Chuan, Jun 6, 2009
  12. 12/23 transport.c::get_refs_via_curl(): do not leak refs_urlTay Ray Chuan, Jun 6, 2009
  13. 13/23 http*: move common variables and macros to http.[ch]Tay Ray Chuan, Jun 6, 2009
  14. 14/23 http: create function end_url_with_slashTay Ray Chuan, Jun 6, 2009
  15. 15/23 http.c: new functions for the http APITay Ray Chuan, Jun 6, 2009
  16. 16/23 transport.c::get_refs_via_curl(): use the new http APITay Ray Chuan, Jun 6, 2009
  17. 17/23 http.c::http_fetch_ref(): use the new http APITay Ray Chuan, Jun 6, 2009
  18. 18/23 http-push.c::remote_exists(): use the new http APITay Ray Chuan, Jun 6, 2009
  19. 19/23 http-push.c::fetch_symref(): use the new http APITay Ray Chuan, Jun 6, 2009
  20. 20/23 http*: add http_get_info_packsTay Ray Chuan, Jun 6, 2009
  21. 21/23 http: use new http API in fetch_index()Tay Ray Chuan, Jun 6, 2009
  22. 22/23 http*: add helper methods for fetching packsTay Ray Chuan, Jun 6, 2009
  23. 23/23 http*: add helper methods for fetching objects (loose)Tay Ray Chuan, Jun 6, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.