[PATCH 10/23] http-push: do not SEGV after fetching a bad pack idx file
- From
Tay Ray Chuan <rctay89@gmail.com>
- Date
- Jun 6, 2009, 08:43 UTC
- Message-ID
- <20090606164337.42b74cfa.rctay89@gmail.com>
- In-Reply-To
- <cover.1244277116.git.rctay89@gmail.com>
In a70c232 ("http-fetch: do not SEGV after fetching a bad pack idx file"), changes were made to the setup_index method in http-fetch.c (known in its present form as http-walker.c after 30ae764 ("Modularize commit-walker")). Since http-push.c has similar similar code for processing index files, these changes should apply to http-push.c's implementation of setup_index as well.
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com> --- http-push.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/http-push.c b/http-push.c index c8cb6e4..a6ca2ac 100644 --- a/http-push.c +++ b/http-push.c @@ -1065,6 +1065,8 @@ static int setup_index(unsigned char *sha1) return -1; new_pack = parse_pack_index(sha1); + if (!new_pack) + return -1; /* parse_pack_index() already issued error message */ new_pack->next = repo->packs; repo->packs = new_pack; return 0; -- 1.6.3.1