git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Add 'git svn reset' to unwind 'git svn fetch'

From
EWEric Wong <normalperson@yhbt.net>
Date
Jun 4, 2009, 00:24 UTC
Message-ID
<20090604002406.GB8882@dcvr.yhbt.net>
In-Reply-To
<20090601174943.GA80846@kronos.home.ben.com>
Ben Jackson <ben@ben.com> wrote:
Show 7 quoted lines
> On Sat, May 30, 2009 at 06:17:07PM -0700, Ben Jackson wrote:
> > Add a command to unwind the effects of fetch by moving the rev_map
> > and refs/remotes/git-svn back to an old SVN revision.
> 
> I just realized this morning that I didn't do any special handling for
> bad revision input.  I will submit a revised patch.  In the mean time
> I would still like feedback on the concept and the docs.
Hi Ben,

Sorry for the late response, I've been distracted with other projects. I like the overall idea of it, it would actually be useful for developing/debugging git-svn as well :)

Show 7 quoted lines
> Known issues:
> 
> 1.  Garbage revision input is accepted and prints several internal errors
> before bombing out.  The repo is not harmed, though.
> 
> 2.  Huge revision numbers cause git-svn to spin for quite a while because
> I used the pre-existing find_rev_before which is a linear search.

find_rev_before can certainly be improved. I haven't noticed performance issues with it myself, but you should be able to improve it.

> 3.  Without --parent it should probably fail for a nonexistent rev rather
> than automatically find_rev_before..

Probably best to ignore the --parent flag and just pass 1 as the second argument to find_rev_before. That's how SVN operations work when a non-exact revision is specified..

-- 
Eric Wong
Previous: Ben JacksonNext: Eric Wong
Message 4 of 5 in “Add 'git svn help [cmd]' which works outside a repo.”
  1. 1/2 Add 'git svn help [cmd]' which works outside a repo.Ben Jackson, May 31, 2009
  2. 2/2 Add 'git svn reset' to unwind 'git svn fetch'Ben Jackson, May 31, 2009
  3. Ben JacksonJun 1, 2009
  4. Eric WongJun 4, 2009
  5. Eric WongJun 4, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.