From: Eric Wong Date: Thu, 04 Jun 2009 00:24:06 GMT Subject: Re: [PATCH 2/2] Add 'git svn reset' to unwind 'git svn fetch' Message-ID: <20090604002406.GB8882@dcvr.yhbt.net> In-Reply-To: <20090601174943.GA80846@kronos.home.ben.com> Ben Jackson wrote: > On Sat, May 30, 2009 at 06:17:07PM -0700, Ben Jackson wrote: > > Add a command to unwind the effects of fetch by moving the rev_map > > and refs/remotes/git-svn back to an old SVN revision. > > I just realized this morning that I didn't do any special handling for > bad revision input. I will submit a revised patch. In the mean time > I would still like feedback on the concept and the docs. Hi Ben, Sorry for the late response, I've been distracted with other projects. I like the overall idea of it, it would actually be useful for developing/debugging git-svn as well :) > Known issues: > > 1. Garbage revision input is accepted and prints several internal errors > before bombing out. The repo is not harmed, though. > > 2. Huge revision numbers cause git-svn to spin for quite a while because > I used the pre-existing find_rev_before which is a linear search. find_rev_before can certainly be improved. I haven't noticed performance issues with it myself, but you should be able to improve it. > 3. Without --parent it should probably fail for a nonexistent rev rather > than automatically find_rev_before.. Probably best to ignore the --parent flag and just pass 1 as the second argument to find_rev_before. That's how SVN operations work when a non-exact revision is specified.. -- Eric Wong