git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 2/2] diff: generate pretty filenames in prep_temp_blob()

From
Jeff King <peff@peff.net>
Date
May 30, 2009, 01:47 UTC
Message-ID
<20090530014751.GA15948@coredump.intra.peff.net>
In-Reply-To
<20090530012204.GA26210@gmail.com>
On Fri, May 29, 2009 at 06:22:05PM -0700, David Aguilar wrote:
Show 10 quoted lines
> > This is such an easily-factorable bit, maybe it makes sense to add as
> > basename() in compat/?
> 
> I would feel a little better calling it
> git_basename(const char *) and keeping it in path.c
> [...]
> All this version cares about is being able to find the
> last dir_sep and returning a pointer.
> 
> What do you think?
That sounds good to me.
-Peff
Previous: David Aguilar
Message 5 of 5 in “compat: add a mkstemps() compatibility function”
  1. 1/2 compat: add a mkstemps() compatibility functionDavid Aguilar, May 29, 2009
  2. 2/2 diff: generate pretty filenames in prep_temp_blob()David Aguilar, May 29, 2009
  3. Jeff KingMay 29, 2009
  4. David AguilarMay 30, 2009
  5. Jeff KingMay 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.