From: Jeff King <peff@peff.net>
Date: Sat, 30 May 2009 01:47:51 GMT
Subject: Re: [PATCH v4 2/2] diff: generate pretty filenames in prep_temp_blob()
Message-ID: <20090530014751.GA15948@coredump.intra.peff.net>
In-Reply-To: <20090530012204.GA26210@gmail.com>

On Fri, May 29, 2009 at 06:22:05PM -0700, David Aguilar wrote:

> > This is such an easily-factorable bit, maybe it makes sense to add as
> > basename() in compat/?
> 
> I would feel a little better calling it
> git_basename(const char *) and keeping it in path.c
> [...]
> All this version cares about is being able to find the
> last dir_sep and returning a pointer.
> 
> What do you think?

That sounds good to me.

-Peff