Re: [PATCH] bash: remove always true if statement from __git_ps1()

From: Shawn O. Pearce <spearce@spearce.org>
Date: May 29, 2009, 15:03 UTC
Message-ID: <20090529150319.GC30527@spearce.org>
In-Reply-To: <1243598436-2207-1-git-send-email-szeder@ira.uka.de>

SZEDER G??bor <szeder@ira.uka.de> wrote:

Show 16 quoted lines

> The recent commits 8763dbb1 (completion: fix PS1 display during a
> merge on detached HEAD, 2009-05-16), ff790b6a (completion: simplify
> "current branch" in __git_ps1(), 2009-05-10), and d7107ca6
> (completion: fix PS1 display during an AM on detached HEAD,
> 2009-05-26) ensure that the branch name in __git_ps1() is always set
> to something sensible.  Therefore, the condition for checking the
> non-empty branch name is always fulfilled, and can be removed.
> 
> Signed-off-by: SZEDER G??bor <szeder@ira.uka.de>
> ---
> 
> The patch is the same, but the commit message is different, because
> Junio's d7107ca6 has fixed the issue.
>
>  contrib/completion/git-completion.bash |   10 ++++------
>  1 files changed, 4 insertions(+), 6 deletions(-)

Yay, code reduction is good.  :-)

Trivially-Acked-by: Shawn O. Pearce <spearce@spearce.org>

-- 
Shawn.