git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] bash: display git prompt in case of merge conflict during rebase

From
SZEDER Gábor <szeder@ira.uka.de>
Date
May 28, 2009, 16:17 UTC
Message-ID
<1243527441-3394-1-git-send-email-szeder@ira.uka.de>

Since e5dd864a (completion: Better __git_ps1 support when not in working directory, 2009-02-11) the git prompt becomes empty, if we hit a merge conflict during a rebase.

e5dd864a added an if statement at the end of __git_ps1 to only display anything in the prompt, if the branch name is not empty. This caused the empty prompt in the "merge conflict during rebase" case, because in this case we display neither the branch name nor the abbreviated SHA1, the ongoing rebase is identified.

This patch removes that check, so the git prompt is displayed even if the branch name is empty.

Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
---
 contrib/completion/git-completion.bash |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 0c8bb53..6c78c94 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -152,12 +152,10 @@ __git_ps1 ()
 			fi
 		fi
 
-		if [ -n "$b" ]; then
-			if [ -n "${1-}" ]; then
-				printf "$1" "$c${b##refs/heads/}$w$i$r"
-			else
-				printf " (%s)" "$c${b##refs/heads/}$w$i$r"
-			fi
+		if [ -n "${1-}" ]; then
+			printf "$1" "$c${b##refs/heads/}$w$i$r"
+		else
+			printf " (%s)" "$c${b##refs/heads/}$w$i$r"
 		fi
 	fi
 }
-- 
1.6.3.1.189.g9321
Next: SZEDER Gábor
Message 1 of 4 in “bash: display git prompt in case of merge conflict during rebase”
  1. bash: display git prompt in case of merge conflict during rebaseSZEDER Gábor, May 28, 2009
  2. SZEDER GáborMay 28, 2009
  3. bash: remove always true if statement from __git_ps1()SZEDER Gábor, May 29, 2009
  4. Shawn O. PearceMay 29, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.